Skip to content

[ffigen] Add C++ public inheritance support (single, multiple, diamond) - #3542

Merged
liamappelbe merged 6 commits into
dart-lang:mainfrom
Hassnaa9:cpp-inheritance
Aug 18, 2026
Merged

[ffigen] Add C++ public inheritance support (single, multiple, diamond)#3542
liamappelbe merged 6 commits into
dart-lang:mainfrom
Hassnaa9:cpp-inheritance

Conversation

@Hassnaa9

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread pkgs/ffigen/lib/src/code_generator/cpp_class.dart Outdated
Comment thread pkgs/ffigen/lib/src/code_generator/cpp_class.dart Outdated
Comment thread pkgs/ffigen/test/native_cpp_test/cpp_inheritance_test.h
@Hassnaa9
Hassnaa9 requested a review from liamappelbe August 13, 2026 04:42

@liamappelbe liamappelbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some formatting errors on CI. The bot is using the most recent stable Dart, which was just released (and makes some small changes to the formatter), so make sure you update to the latest version.

Comment thread pkgs/ffigen/lib/src/code_generator/cpp_class.dart Outdated
Comment thread pkgs/ffigen/lib/src/header_parser/sub_parsers/classdecl_parser.dart Outdated
Comment thread pkgs/ffigen/lib/src/code_generator/cpp_class.dart
Comment thread pkgs/ffigen/lib/src/code_generator/cpp_class.dart Outdated
Comment thread pkgs/ffigen/lib/src/header_parser/sub_parsers/classdecl_parser.dart Outdated
Comment thread pkgs/ffigen/lib/src/visitor/copy_methods_from_super_type.dart Outdated
@Hassnaa9
Hassnaa9 requested a review from liamappelbe August 17, 2026 00:40

@liamappelbe liamappelbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The diffs are quite small now. Looks good.

@liamappelbe
liamappelbe merged commit b461222 into dart-lang:main Aug 18, 2026
42 checks passed
@dcharkes

Copy link
Copy Markdown
Collaborator

Did we have a merge conflict? The CI is red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants